public/hass-oidc-auth
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not reveal existance of trusted networks provider (#302)

Browse Source 
* Skip welcome page if the only other provider is trusted networks

* Add test
This commit is contained in:
Christiaan Goossens
2026-05-01 14:27:23 +02:00
committed by GitHub
parent c7370ed266
commit d3c359064d
2 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
custom_components/auth_oidc/__init__.py
View File

@@ -100,10 +100,10 @@ async def _register_oidc_provider(hass: HomeAssistant, my_config: dict):
existing_auth_providers = hass.auth._providers.copy()
_LOGGER.debug("Current auth providers: %s", list(existing_auth_providers.keys()))
has_other_auth_providers = len(existing_auth_providers) > 0
auth_provider_count = len(existing_auth_providers)
has_trusted_networks_provider_first = False
if has_other_auth_providers:
if auth_provider_count > 0:
# Pop the first provider from the existing providers to check if it's trusted_networks
first_provider_key, first_provider_obj = next(
iter(existing_auth_providers.items())
@@ -133,14 +133,15 @@ async def _register_oidc_provider(hass: HomeAssistant, my_config: dict):
# pylint: enable=protected-access
_LOGGER.info("Registered OIDC provider")
return provider, has_other_auth_providers, has_trusted_networks_provider_first
return provider, auth_provider_count, has_trusted_networks_provider_first
# pylint: disable=too-many-locals
async def _setup_oidc_provider(hass: HomeAssistant, my_config: dict, display_name: str):
"""Set up the OIDC provider with the given configuration."""
(
provider,
has_other_auth_providers,
auth_provider_count,
has_trusted_networks_provider_first,
) = await _register_oidc_provider(hass, my_config)
@@ -195,14 +196,18 @@ async def _setup_oidc_provider(hass: HomeAssistant, my_config: dict, display_nam
]
)
has_only_trusted_networks = (
auth_provider_count == 1 and has_trusted_networks_provider_first
)
hass.http.register_view(
OIDCWelcomeView(
provider,
OIDCWelcomeOptions(
name=name,
force_https=force_https,
has_other_auth_providers=has_other_auth_providers,
prefers_skipping=default_redirect,
has_other_auth_providers=auth_provider_count > 0,
prefers_skipping=default_redirect or has_only_trusted_networks,
),
)
)