From 0461610ebd7a76cbe19cfa7ea3f55bb976ff5d49 Mon Sep 17 00:00:00 2001
From: yangdsh <dongshen@andrew.cmu.edu>
Date: Sat, 28 Mar 2020 00:34:36 +0000
Subject: [PATCH] load knob range

---
 server/website/website/models.py | 13 +++++++++----
 server/website/website/views.py  |  3 ++-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/server/website/website/models.py b/server/website/website/models.py
index b896a91..9cefd2c 100644
--- a/server/website/website/models.py
+++ b/server/website/website/models.py
@@ -252,7 +252,9 @@ class SessionKnobManager(models.Manager):
 
     @staticmethod
     def get_knob_min_max_tunability(session, tunable_only=False):
-        # Returns a dict of the knob
+        # This method returns only min, max, and tunability of session knobs
+        # It is only used in the manage command 'dumpknob'
+        # It is deprecated. We should use function get_knobs_for_session(session)
         filter_args = dict(session=session)
         if tunable_only:
             filter_args['tunable'] = True
@@ -274,9 +276,12 @@ class SessionKnobManager(models.Manager):
         for lower_name, session_knob in session_knobs.items():
             if lower_name in knob_dicts:
                 settings = knob_dicts[lower_name]
-                session_knob.minval = settings["minval"]
-                session_knob.maxval = settings["maxval"]
-                session_knob.tunable = settings["tunable"]
+                if "minval" in settings:
+                    session_knob.minval = settings["minval"]
+                if "maxval" in settings:
+                    session_knob.maxval = settings["maxval"]
+                if "tunable" in settings:
+                    session_knob.tunable = settings["tunable"]
                 if "upperbound" in settings:
                     session_knob.upperbound = settings["upperbound"]
                 if "lowerbound" in settings:
diff --git a/server/website/website/views.py b/server/website/website/views.py
index 71e8c71..1891cce 100644
--- a/server/website/website/views.py
+++ b/server/website/website/views.py
@@ -1591,7 +1591,8 @@ def alt_create_or_edit_session(request):
     sk = SessionKnob.objects.get_knobs_for_session(session)
     sess_knobs = {}
     for knob in sk:
-        sess_knobs[knob['name']] = {x: knob[x] for x in ('minval', 'maxval', 'tunable')}
+        sess_knobs[knob['name']] = {x: knob[x] for x in ('minval', 'maxval', 'tunable',
+                                                         'upperbound', 'lowerbound')}
     res['session_knobs'] = sess_knobs
 
     if warnings: