From 6d854b86acef7ecad26b75a9b9781e779c80c74f Mon Sep 17 00:00:00 2001
From: dvanaken <dvanaken@cs.cmu.edu>
Date: Thu, 14 May 2020 12:11:42 -0400
Subject: [PATCH] Updated enumvals for oracle knob use_large_pages

---
 .../knob_settings/oracle/create_knob_settings.py       |  9 +++++----
 server/website/website/fixtures/oracle-121_knobs.json  |  6 +++---
 server/website/website/fixtures/oracle-12_knobs.json   | 10 +++++-----
 server/website/website/fixtures/oracle-19_knobs.json   | 10 +++++-----
 4 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/server/website/script/fixture_generators/knob_settings/oracle/create_knob_settings.py b/server/website/script/fixture_generators/knob_settings/oracle/create_knob_settings.py
index c034e6d..6dfa7e4 100644
--- a/server/website/script/fixture_generators/knob_settings/oracle/create_knob_settings.py
+++ b/server/website/script/fixture_generators/knob_settings/oracle/create_knob_settings.py
@@ -387,9 +387,9 @@ def set_field(fields):
     if fields['name'].lower() == 'approx_for_percentile':
         fields['minval'] = None
         fields['maxval'] = None
-        fields['default'] = False
+        fields['default'] = 'NONE'
         fields['vartype'] = 5
-        fields['enumvals'] = 'none,NONE,PERCENTILE_CONT,PERCENTILE_CONT DETERMINISTIC,PERCENTILE_DISC,PERCENTILE_DISC DETERMINISTIC,ALL,ALL DETERMINISTIC'
+        fields['enumvals'] = 'NONE,PERCENTILE_CONT,PERCENTILE_CONT DETERMINISTIC,PERCENTILE_DISC,PERCENTILE_DISC DETERMINISTIC,ALL,ALL DETERMINISTIC'
     if fields['name'].lower() == 'session_cached_cursors':
         fields['minval'] = 0
         fields['maxval'] = 100
@@ -397,8 +397,9 @@ def set_field(fields):
     if fields['name'].lower() == 'use_large_pages':
         fields['minval'] = None
         fields['maxval'] = None
-        fields['default'] = True
-        fields['vartype'] = 4
+        fields['default'] = 'TRUE'
+        fields['vartype'] = 5
+        fields['enumvals'] = 'TRUE,FALSE,ONLY'
     if fields['name'].lower() == 'hs_autoregister':
         fields['minval'] = None
         fields['maxval'] = None
diff --git a/server/website/website/fixtures/oracle-121_knobs.json b/server/website/website/fixtures/oracle-121_knobs.json
index 36002e6..4428dd4 100644
--- a/server/website/website/fixtures/oracle-121_knobs.json
+++ b/server/website/website/fixtures/oracle-121_knobs.json
@@ -7343,15 +7343,15 @@
             "scope": "global",
             "dbms": 121,
             "category": "",
-            "enumvals": null,
+            "enumvals": "TRUE,FALSE,ONLY",
             "context": "",
             "unit": 3,
             "tunable": false,
             "description": "",
             "minval": null,
             "maxval": null,
-            "vartype": 4,
-            "default": true,
+            "vartype": 5,
+            "default": "TRUE",
             "summary": "Use large pages if available (TRUE/FALSE/ONLY)"
         }
     },
diff --git a/server/website/website/fixtures/oracle-12_knobs.json b/server/website/website/fixtures/oracle-12_knobs.json
index ccac33e..701300b 100644
--- a/server/website/website/fixtures/oracle-12_knobs.json
+++ b/server/website/website/fixtures/oracle-12_knobs.json
@@ -237,7 +237,7 @@
             "scope": "global",
             "dbms": 12,
             "category": "",
-            "enumvals": "none,NONE,PERCENTILE_CONT,PERCENTILE_CONT DETERMINISTIC,PERCENTILE_DISC,PERCENTILE_DISC DETERMINISTIC,ALL,ALL DETERMINISTIC",
+            "enumvals": "NONE,PERCENTILE_CONT,PERCENTILE_CONT DETERMINISTIC,PERCENTILE_DISC,PERCENTILE_DISC DETERMINISTIC,ALL,ALL DETERMINISTIC",
             "context": "",
             "unit": 3,
             "tunable": false,
@@ -245,7 +245,7 @@
             "minval": null,
             "maxval": null,
             "vartype": 5,
-            "default": false,
+            "default": "NONE",
             "summary": "Replace percentile_* with approx_percentile"
         }
     },
@@ -8027,15 +8027,15 @@
             "scope": "global",
             "dbms": 12,
             "category": "",
-            "enumvals": null,
+            "enumvals": "TRUE,FALSE,ONLY",
             "context": "",
             "unit": 3,
             "tunable": false,
             "description": "",
             "minval": null,
             "maxval": null,
-            "vartype": 4,
-            "default": true,
+            "vartype": 5,
+            "default": "TRUE",
             "summary": "Use large pages if available (TRUE/FALSE/ONLY)"
         }
     },
diff --git a/server/website/website/fixtures/oracle-19_knobs.json b/server/website/website/fixtures/oracle-19_knobs.json
index 1af53cb..5994c6d 100644
--- a/server/website/website/fixtures/oracle-19_knobs.json
+++ b/server/website/website/fixtures/oracle-19_knobs.json
@@ -294,7 +294,7 @@
             "scope": "global",
             "dbms": 19,
             "category": "",
-            "enumvals": "none,NONE,PERCENTILE_CONT,PERCENTILE_CONT DETERMINISTIC,PERCENTILE_DISC,PERCENTILE_DISC DETERMINISTIC,ALL,ALL DETERMINISTIC",
+            "enumvals": "NONE,PERCENTILE_CONT,PERCENTILE_CONT DETERMINISTIC,PERCENTILE_DISC,PERCENTILE_DISC DETERMINISTIC,ALL,ALL DETERMINISTIC",
             "context": "",
             "unit": 3,
             "tunable": false,
@@ -302,7 +302,7 @@
             "minval": null,
             "maxval": null,
             "vartype": 5,
-            "default": false,
+            "default": "NONE",
             "summary": "Replace percentile_* with approx_percentile"
         }
     },
@@ -8559,15 +8559,15 @@
             "scope": "global",
             "dbms": 19,
             "category": "",
-            "enumvals": null,
+            "enumvals": "TRUE,FALSE,ONLY",
             "context": "",
             "unit": 3,
             "tunable": false,
             "description": "",
             "minval": null,
             "maxval": null,
-            "vartype": 4,
-            "default": true,
+            "vartype": 5,
+            "default": "TRUE",
             "summary": "Use large pages if available (TRUE/FALSE/ONLY)"
         }
     },