public/ottertune
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The Oracle collector now prepends the view name to each metric to avoid overwriting metrics from different views with the same names

Browse Source
This commit is contained in:
dvanaken
2019-11-05 11:05:39 -05:00
committed by Dana Van Aken
parent 6283186d76
commit d874ca6a8b
19 changed files with 11949 additions and 20017 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
client/controller/src/main/java/com/controller/collectors/OracleCollector.java
View File

@@ -25,11 +25,16 @@ public class OracleCollector extends DBCollector {
private static final String VERSION_SQL = "select VERSION from product_component_version";
private static final String PARAMETERS_SQL = "select name, value from v$parameter";
private static final String PARAMETERS_SQL =
"select name, value from v$parameter";
private static final String PARAMETERS_SQL_WITH_HIDDEN =
"select x.ksppinm name, y.ksppstvl value from sys.x$ksppi x, sys.x$ksppcv y where"
+ " x.inst_id = userenv('Instance') and y.inst_id = userenv('Instance') and x.indx = y.indx";
"select x.ksppinm name, y.ksppstvl value "
+ "from sys.x$ksppi x, sys.x$ksppcv y "
+ "where x.inst_id = userenv('Instance') "
+ "and y.inst_id = userenv('Instance') "
+ "and x.indx = y.indx "
+ "and x.ksppinm like '/_%' ESCAPE '/'";
private static final String METRICS_SQL = "select name, value from v$sysstat";
@@ -54,14 +59,18 @@ public class OracleCollector extends DBCollector {
}
// Collect DBMS internal metrics
String key;
out = statement.executeQuery(METRICS_SQL);
while (out.next()) {
dbMetrics.put(out.getString(1).toLowerCase(), out.getString(2));
key = "sysstat." + out.getString(1).toLowerCase();
dbMetrics.put(key, out.getString(2));
}
out = statement.executeQuery(METRICS_SQL2);
while (out.next()) {
dbMetrics.put(out.getString(1).toLowerCase(), out.getString(2));
key = "sys_time_model." + out.getString(1).toLowerCase();
dbMetrics.put(key, out.getString(2));
}
out = statement.executeQuery(METRICS_SQL3);
@@ -74,9 +83,9 @@ public class OracleCollector extends DBCollector {
while (out.next()) {
String eventName = out.getString(1).toLowerCase();
for (int i = 2; i <= columnCount; ++i) {
String name = eventName + "." + columnNames[i - 1];
key = "system_event." + eventName + "." + columnNames[i - 1];
Object value = out.getObject(i);
dbMetrics.put(name, String.valueOf(value));
dbMetrics.put(key, String.valueOf(value));
}
}