Added support for Oracle v12.1c.

server/website/script/fixture_generators/knob_settings/oracle/.gitignore

@@ -0,0 +1 @@
+oracle-*_knobs.json

server/website/script/fixture_generators/knob_settings/oracle/create_knob_settings.py

@@ -6,7 +6,6 @@
 import csv
 import json
 import shutil
-from collections import OrderedDict
 from operator import itemgetter
 
 # Oracle Type:
@@ -161,19 +160,12 @@ def set_field(fields):
 
 COLNAMES = ("NAME", "TYPE", "DEFAULT_VALUE", "DESCRIPTION")
 
-# DB_VERSIONS = {
-#     '19': 19,
-#     '12': 12,
-#     '12.1': 121,
-# }
 
-
-def process_version(version, dbms_id, delim=','):
+def process_version(version, delim=','):
     fields_list = []
     with open('oracle{}.csv'.format(version), 'r', newline='') as f:
         reader = csv.reader(f, delimiter=delim)
         header = [h.upper() for h in next(reader)]
-        # header = ["NUM","NAME","TYPE","VALUE","DISPLAY_VALUE","DEFAULT_VALUE","ISDEFAULT","ISSES_MODIFIABLE","ISSYS_MODIFIABLE","ISPDB_MODIFIABLE","ISINSTANCE_MODIFIABLE","ISMODIFIED","ISADJUSTED","ISDEPRECATED","ISBASIC","DESCRIPTION","UPDATE_COMMENT","HASH","CON_ID"]
         idxs = [header.index(c) for c in COLNAMES]
         ncols = len(header)
 
@@ -188,7 +180,6 @@ def process_version(version, dbms_id, delim=','):
                 if cname == 'NAME':
                     fields['name'] = value.upper()
                 elif cname == 'TYPE':
-                    print('TYPE: {}'.format(value))
                     value = int(value)
                     if value == 1:
                         fields['vartype'] = 4  # Boolean
@@ -203,7 +194,7 @@ def process_version(version, dbms_id, delim=','):
 
                 fields.update(
                     scope='global',
-                    dbms=dbms_id,
+                    dbms=version,
                     category='',
                     enumvals=None,
                     context='',
@@ -224,12 +215,13 @@ def process_version(version, dbms_id, delim=','):
     filename = 'oracle-{}_knobs.json'.format(version)
     with open(filename, 'w') as f:
         json.dump(final_metrics, f, indent=4)
-    # shutil.copy(filename, "../../../../website/fixtures/{}".format(filename))
+    shutil.copy(filename, "../../../../website/fixtures/{}".format(filename))
+
 
 def main():
-    process_version('19', 19)
-    # process_version('12', 12)
-    process_version('12.1', 121, delim='|')
+    process_version(19)
+    # process_version(12)
+    process_version(121, delim='|')
 
 
 if __name__ == '__main__':